Skip to content

[bazel] Flag fixes for the RBE#16785

Merged
shs96c merged 1 commit intoSeleniumHQ:trunkfrom
shs96c:flag-fixes
Dec 23, 2025
Merged

[bazel] Flag fixes for the RBE#16785
shs96c merged 1 commit intoSeleniumHQ:trunkfrom
shs96c:flag-fixes

Conversation

@shs96c
Copy link
Member

@shs96c shs96c commented Dec 23, 2025 •
edited by qodo-code-review bot
Loading

User description

The c++ version is set properly in the main .bazelrc and changing it here doesn't help.

We should also always use a pinned browser in the RBE.

PR Type

Enhancement

Description

  • Add browser pinning flag for RBE builds

  • Remove redundant C++ standard flag from RBE config

  • Simplify remote build configuration

Diagram Walkthrough

flowchart LR
  A["RBE Configuration"] -->|Add pin_browsers flag| B["Browser Pinning Enabled"]
  A -->|Remove cxxopt flag| C["Simplified Config"]
  B --> D["Remote Build Execution"]
  C --> D
Loading

File Walkthrough
Relevant files
Configuration changes
.bazelrc.remote
Update RBE configuration flags                                                     

.bazelrc.remote

  • Added --//common:pin_browsers flag to ensure pinned browsers in RBE
    builds
  • Removed redundant --cxxopt=-std=c++14 flag (already set in main
    .bazelrc)
  • Added clarifying comment for browser pinning configuration
 +3/-1     

@shs96c
[bazel] Flag fixes for the RBE
03928fe 
The c++ version is set properly in the main `.bazelrc` and
changing it here doesn't help.

We should also always use a pinned browser in the RBE.
@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Dec 23, 2025
@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Dec 23, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
⚪
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Dec 23, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Add explicit flag value

Append =true to the --//common:pin_browsers flag to explicitly set its value,
which is the required syntax for boolean build settings in Bazel.

.bazelrc.remote [11]

-build:rbe --//common:pin_browsers
+build:rbe --//common:pin_browsers=true
  • Apply / Chat
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies that user-defined Bazel flags should have their boolean values set explicitly to prevent potential parsing issues and ensure the intended configuration is applied.

Medium
  • More

@shs96c shs96c merged commit fb478af into SeleniumHQ:trunk Dec 23, 2025
12 checks passed
@shs96c shs96c deleted the flag-fixes branch December 23, 2025 11:27
@titusfortner
Copy link
Member

titusfortner commented Dec 23, 2025

@shs96c default value is true for pin_browsers now: #16743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

B-build Includes scripting, bazel and CI integrations Review effort 1/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shs96c @titusfortner @selenium-ci